equinixmetal-archive/packngo

Missing fields for VirtualNetwork type

displague opened this issue · 2 comments

The following fields returned from a virtual network attachment request are not mapped in the packngo VirtualNetwork resources.

assigned_to: *Project (with only href populated)
facility: *Facility
instances: []
internet_gateway: null (I don't know the type here)

Some of these fields are not documented, which is apparent from the generated client:

https://github.com/t0mk/gometal/blob/main/types/virtual_network.go

The internet_gateway field may be a dead field related to the dead /virtual-networks/{id}/internet-gateways endpoint (which is included in Swagger).

Hold off on implementing this.

assigned_to is already present in packngo VirtualNetwork as Project (rather than AssignedTo).

This makes me wonder about how other references are named. The endpoint includes instances. Should packngo call these VirtualNetwork.Devices?