Upgrade newsroom
Closed this issue · 13 comments
@BorghildSelle @meols The latest version is looking great. No major comments.
One small thing on the filters, we talked about a CLEAR ALL option if a user has gone crazy with the filter options.
Otherwise good from the design side.
Suggest the below image to be coded in for News articles that are missing images. If its possible to pull from a few options (for variations) let me know and I can upload more. But one is fine too :)
@NickHaggerty1 Will do!
@meols @NickHaggerty1 The newsroom is updated now and can be tested.
Criterias:
- Possible to filter news on different tags
- Can remove filters and clear all
- Can quick search on keyword
- Looks good in mobile and desktop
- Can tab through newsroom with access to all interactive elements
- all news have thumbnail images
@BorghildSelle @meols Hey, tested on the above and looks good to me. Little repetitive with the images when filtering to older news items but dont think we need to worry about this too much.
@BorghildSelle - looks good with regards to the test cases listed - but I don't see the image update on the top news. Even tried to republish it again today. Also I don't see the two latest articles I published today, neither on the new/English newsroom or the old/Norwegian news room. Only one of the articles is visible in the three articles at the bottom of each article. Also I created a new tag (Test) and used it as a topic tag, but it isn't added to the topic filters.
(Not sure how/if custom date and tags plays a part in this)
@meols The news articles not getting updated is expected as I have paused indexing for dev environment.
@padms @BorghildSelle - the newsroom looks good and updated - but when I click to filter on the new Test tag i created I got this result (both in Chrome and Edge)
I get the more or less the same look when filtering on Ireland as a topic. Is it relevant that both have "No relevant content..." for Country - which probably can happen in "real life use" as well.
Assuming we will have the new newsroom in Norwegian as well, even if it isn't "activated" on dev/stage?
@meols I will look into these :)
