Deprecate usage of `app` in plugin signatures?
Opened this issue · 2 comments
Since after plotly/dash#1718 @dash.callback can be used. Need to check if the app object has use cases besides @app.callback first.
Deprecation of app might need to be accompanied with a feature in webviz-config regarding setting app.server.route.
Without any accompanying logic, this would be a breaking change for caramba-webviz. We have reusable sub-components that take Inputs/outputs in during initialization, and configure the callbacks for different use cases.
If the callback registration is changed to only happen with the @dash.callback decorator, this can not work. This also means that such component never can be supported, since they would need to a-priori know e.g. what to take input or output from.
nvm, misunderstood how the change would work. I would be concerned if the app is not at all propagated down to plugins however. As we saw in #535 having access to the app object allows us to implement hotfixes to e.g. oauth in downstream projects without too much hassle.