eradman/entr

Tests are failing on archlinux

hartmark opened this issue · 3 comments

I'm the maintainer of the entr-git AUR-package on arch linux.
https://aur.archlinux.org/packages/entr-git

Last change seem to break some test.

% make test
./system_test.sh
..................s.........................egrep: warning: egrep is obsolescent; using grep -E
.warning: in the working copy of 'tinyxml2.h', CRLF will be replaced by LF the next time Git touches it
ls: write error: Broken pipe
.......................
FAIL: ensure watches operate on a running executable
'vroom' != 'vroom
vroom'
make: *** [Makefile.bsd:9: test] Error 1

git bisect gives me this as the first breaking commit.

2d17193d274510f949f2cd260b954a6721ec90eb is the first bad commit
commit 2d17193d274510f949f2cd260b954a6721ec90eb
Author: Eric Radman <ericshane@eradman.com>
Date:   Mon Jan 16 16:30:28 2023 -0500

    Ignore NOTE_ATTRIB event indicating inode changes unless '-a' is specified
    
    MacOS emits these asynchronously after other change events.

 NEWS   | 1 +
 entr.1 | 5 +++--
 entr.c | 6 +++---
 3 files changed, 7 insertions(+), 5 deletions(-)

@hartmark thanks for catching this. You're right, and this is reproducible on other Linux distributions as well. I'll adjust the previous commit to re-enable this behavior on Linux.

Fixed in commit 828a2a4

Thanks for quick fix!