erasureprotocol/erasure-protocol

Purpose of Operated. _status is unclear

fulldecent opened this issue · 1 comments

The purpose of _status is unclear. All functions based on this variable seem to have no end-user value.

Recommendation: First consider if this is needed at all. Please note that messages cannot be sent by address(0) so currently, all status check is redundant.

Review if _activateOperator, _deactivateOperator, _transferOperator, _renounceOperator, hasActiveOperator, isActiveOperator are necessary.

If keeping, consider switching _status to an enum or adding documentation.

If removing, just check whether the operator is address(0)

References:

agree status is redundant