ericabouaf/aws-swf

event_list.has_schedule_activity_task_failed is not detecting ACTIVITY_TYPE_DOES_NOT_EXIST

saverchenkov opened this issue · 0 comments

decisionTask.eventList.failed(activityId) returns false when this activityId is in fact failed.

I tried to trace the code through the debugger, and the way it is implemented right now, activityIdFor in event-list.js on line 19 receives scheduledEventId === undefined

screen shot 2014-03-06 at 3 48 32 pm
screen shot 2014-03-06 at 3 50 56 pm

I was able to fix this issue by doing this:

has_schedule_activity_task_failed: function (activityId) {
   return this._has_eventType_for_activityId(activityId, 'ScheduleActivityTaskFailed');
},