ericcornelissen/pinned-tabs-for-atom

enableVcsColoring style from Material UI theme

Closed this issue · 5 comments

jerone commented

There's a small issue with the enableVcsColoring indicator from the Material UI theme being removed:

atom pinned tabs material ui

Steps to reproduce:

  1. Install Atom Material UI theme.
  2. Enable the enableVcsColoring setting from the tabs package.
  3. Alter a git file.

Atom v1.6.0-beta8
Windows 7
atom-material-ui@1.2.6
pinned-tabs@0.1.13

ericcornelissen commented

Are you entirely sure it is caused solely by the enableVcsColoring setting from Atom Material UI ? I am unable to reproduce the issue with this setup (My guess is it has to do with Atom v1.6.0-beta8):
Atom v1.5.4
atom-material-ui@1.2.6 as UI Theme
Atom Dark as Syntax Theme
pinned-tabs@0.1.13

jerone commented

Are you entirely sure it is caused solely by the enableVcsColoring setting from Atom Material UI ?

Yes, just did a clean profile, installed Pinned Tabs, set Material UI as theme, enabled enableVcsColoring on the Tabs package and got exactly the same result on an altered file.

ericcornelissen commented

I got it 😄 The problem is that both are using the :after of the title element... Its kinda hard to fix this, but I've been working on this on a seperate branch (where I use file-icons as a dependencies). I'll speed this process up a bit so this bug will be fixed soon 👍

  • 👍1
ericcornelissen commented

The issue should be fixed in v0.2.0 🎉 Let me know if you still have problems...

jerone commented

Confirmed and thanks!

  • 👍1