Add support for git-control
Wombosvideo opened this issue · 5 comments
Please add icon support for the git-control package. By default it doesn't have one but it would be nice if it had a GIT icon when pinned
I think it is better if the icon would be provided by another package, such as file-icons. However, the git-control package is not implemented such that file-icons can give it an icon. I will go ahead and try to get both packages to update their code to support this if you want.
Also, is their any particular reason why you said when pinned (in bold)? Is it really necessary that the icon is not there when it is not pinned? And in that case, would it be an idea to add an option to this package to hide icons when the tab is not pinned?
I will go ahead and try to get both packages to update their code to support this if you want.
Great
Is it really necessary that the icon is not there when it is not pinned?
No it's not but since it only has one when pinned I thought... Well... scrap it and show the icon all the time. Don't know why I put it in bold
And in that case, would it be an idea to add an option to this package to hide icons when the tab is not pinned?
I wouldn't personally use this option but I think it could be quite useful when having many tabs open so you have more space for the text label. Yes, if possible, add this functionality.
@Wombosvideo, do you still want this feature? Given that with Atom 1.18 there is git control build into Atom, and given that the atom-git-control repository seems to have been abandoned...
If not I'll close this issue 🙂
It seems the atom-git-control repo has lost interest again... I will close this issue for now, any further remarks @Wombosvideo?
No, this is fine. I don't use that plugin very often anymore