ericcornelissen/shescape

Update CI fuzz tests to not use `set-output`

Closed this issue · 5 comments

ericcornelissen commented

Task

Description

The fuzz tests currently in the CI use set-output (as echo "::set-output name=xxx::$yyy"), which is an GitHub Actions' feature that has been deprecated an may be disabled in the future.

To ensure the fuzz tests in the CI keep working, they should be updated to not use set-output (or save-state) anymore.

Based on github/codeql-action@v2.1.27...v2.1.28 it looks like changing the workflow as follows should work:

- echo "::set-output name=xxx::$yyy"
+ echo "xxx=$yyy" >> $GITHUB_OUTPUT
samkcrespo commented

Can I be assigned to this?

ericcornelissen commented

Done @samkcrespo, looking forward to your Pull Request

samkcrespo commented

I am not finding any documenation regarding if line 131 should have >> $GITHUB_OUTPUT after or before $EXIT_CODE

ericcornelissen commented

@samkcrespo, >> $GITHUB_OUTPUT should come after the $EXIT_CODE.

For some background, >> is a shell operator. You can read more about it online, for example this ask ubuntu answer might explain it some more 🙂

  • 👀1