Replace Minimatch by @actions/glob
Closed this issue · 2 comments
Task
Description
Replace minimatch by @actions/glob. As @actions/glob currently uses minimatch under the hood this shouldn't result in breaking changes.
Notes
It should be ensured that globs are processed by-and-large in the same way as other actions.
The API of @actions/glob currently does not align with how globs are used - it is missing a function to test a specific path against a glob. Hence, switching to @actions/glob is not trivial (it would require rewriting the file-systems package to accommodate its API). Since minimatch is still fine as dependency it does not make sense to switch to @actions/glob now.
Switching from minimatch to @actions/glob should be considered as part of a rewrite in the future given the considerations in the issue description.
Reconsidering this issue with the target of including the changes in the v4 milestone. With the choice of a major version to avoid any accidental breaking changes due to the change.