ericdude4/shopifex

Could the phoenix_html version requirement be relaxed to include 3.0?

mfilej opened this issue · 5 comments

mfilej commented

I was wondering whether the version requirement for phoenix_html could be changed to support 3.0. Is there any known issue?

shopifex/mix.exs

Line 57 in c9a1977

{:phoenix_html, "~> 2.11"},

ericdude4 commented

@mfilej Sure! I don't know of any issues with this. Are you willing to make this PR?

mfilej commented

@ericdude4 Sure thing, will give it a go and make a PR if everything works out ok.

  • 👍1
mfilej commented

It seems that this was fixed in #32.

  • 👍1
ericdude4 commented

@mfilej Yes, we removed the dependency on :react_phoenix from Shopifex in 3275150. Hope you're all doing well. Cheers!

  • 👍1