ericmdantas/generator-ng-fullstack

Name convention problems upon using generator

marvedly opened this issue · 5 comments

marvedly commented

Hi!

When I use the ngf generator for generating for example a component for Angular 2, it doesn't seem to follow the style guide from Angular Style Guide. Is there a reason for this?

ericmdantas commented

Hey, @barajagmartin.

This is mostly because when the generator was created there was no such style guide for Angular2 yet. So some stuff were just kept as they were.

Are there any specific styles you'd like to see implemented?

marvedly commented

Okay! Hmm, if I wrote $ ngf g component car --feat car as in the ngf wiki it would be nice if:

  • the "feature folder" would be called car
  • the component would be called: car.component.ts
  • the class would be called: CarComponent

The same would go for services etc.

Do you understand what I mean?

ericmdantas commented

Yup, sounds good.

marvedly commented

Also, in service for example, the name is MyService instead of the name when being generated.

Commit 29d7b46

Thanks!

ericmdantas commented

Will be solved in ericmdantas/ngf#4