Don't include Newtonsoft.Json.dll in the NuGet package
Closed this issue · 9 comments
Please update the version of your Newtonsoft.Json nuget package to the latest version.
My Project crashed after I installed your package because I was using the Newtonsoft.Json package in some of my libraries.
This is more of a Nuget dependencies problem. Nuget should be notifying you that this library is bound to v8 of jsonlib and should update the web.config assemblies section accordingly.
This really goes way back to my assertions to the .Net team that the fusion binder should start following semver semantics and soon.
The main issue is that other projects that might still use v8 will break when I move this one forward.
I'm having this issue as well. Other libraries and projects in my solution are breaking because they need Newtonsoft.Json 9.0.1, but yet it gets overwritten with version 8.0.1 due to the 8.0.1 DLL being included with this library.
When it comes to Nuget, I think the reason why Nuget doesn't notify users is because the actual Newtonsoft.Json DLL is included in your Nuget package, rather than using a reference to the Newtonsoft.Json's Nuget package. If you switch over to using the reference to the package, I'd think you can specify which versions of the package you support. This being said, I've not much experience with publishing things to Nuget.
Is the problem, that the nuget package of gmaps-api-net contains a copy of Newtonsoft.Json.dll in version 8.0.1?
@sven-s we don't include the Json.dll in our nuget package, just a reference to Newtonsoft.Json v8.0.1 at the time.
@agenthala @JaykeBird still having this problem?
Of note:
there's a change coming down that will push our Json.net reference to v10 related to Issue #84
@ericnewton76 That is not true. Just downloaded the latest version from nuget and unzipped the package. In the lib/net directory is a copy of Newtonsoft.Json.dll.
Fyi, released v0.18.70 which should solve this problem