sp_QuickieStore: Should the bottom table give datetimes rather than dates?
Closed this issue · 2 comments
Is your feature request related to a problem? Please describe.
I'm always frustrated when I use sp_QuickieStore and look for things that happened on a specific date. The bottom table gives a useless report in its period column like "query store data for period 2024-05-11 through 2024-05-11". This information also does nothing to help my tendency to forget if I need to add a UTC conversion to @start_date.
Describe the solution you'd like
Make the date shown a datetime, rather than just a date. Put it in the same format that @start_date wants, rather than whatever the user provided.
Describe alternatives you've considered
Just leave it alone. Datetimes add clutter that we may want to avoid.
Then again, if clutter is an issue, then the above example can be cut down to just "2024-05-11–2024-05-11". The en dash carries most of the weight of the sentence, unless I'm forgetting some quirk of the British/American disagreements on how to use dashes. The bits that the en dash doesn't cover were already redundant. After all, the user obviously knows that they're looking at Query Store data.
Are you ready to build the code for the feature?
Maybe, but only if we agree on the correct path first.
@ReeceGoding did you work on this in #431 or was i hallucinating?
@erikdarlingdata Hallucinating. The new IF block seems to throw off GitHub's comparison feature, probably due to the indentation. #431 added a tiny amount of code, none of which changed this. Indentation aside, I don't think that period is any different between main and dev.