erikdubbelboer/phpRedisAdmin

2 changes I'd like to implement

tessus opened this issue · 4 comments

The current code shows all databases with no information:

image

I'd like to implement 2 changes:

  • add a count next to the name (and shorten the name to db)
    database 0 with 666 keys would then look like this: db 0 (666) or db0 (666)
  • create an option to list only databases with keys

Please let me know what you think. I can create a PR or 2...

Sounds like a good idea. You can combine it in one PR.

Cool, it would look like this:

image

Or do you want to keep the prefix database ?

image

Default value

Also, what should be the default? Hiding or showing empty databases?

The Redis documentation says database so lets keep that I guess.

I think the default should be to show empty databases. Not showing them might confuse users who have a database but then don't see it.

The Redis documentation says database so lets keep that I guess.

Right, but internally (e.g. config output) they are always referenced as dbX. I've added a variable (not an option), so you can change it easily.

I think the default should be to show empty databases. Not showing them might confuse users who have a database but then don't see it.

Ok, makes sense.

PR's coming up in a sec.