erlangbureau/jamdb_oracle

Warnings after upgrade to 0.5.0

Closed this issue · 4 comments

winks commented

Hi,
I upgraded jamdb_oracle from 0.4.12 to 0.5.0, ecto from 3.7.1 to 3.8.3 and ecto_sql from 3.7.2 to 3.8.1 today and I get a ton of warnings on startup, but everything still seems to work fine (but I don't think I am using any advanced features).

Happy to provider further info if needed.

warning: module attribute @impl was not set for function update_all/1 callback (specified in Ecto.Adapters.SQL.Connection). This either means you forgot to add the "@impl true" annotation before the definition or that you are accidentally overriding this callback
  lib/jamdb_oracle_ecto.ex:134: Ecto.Adapters.Jamdb.Oracle.Connection (module)

warning: module attribute @impl was not set for function update/5 callback (specified in Ecto.Adapters.SQL.Connection). This either means you forgot to add the "@impl true" annotation before the definition or that you are accidentally overriding this callback
  lib/jamdb_oracle_ecto.ex:137: Ecto.Adapters.Jamdb.Oracle.Connection (module)

warning: module attribute @impl was not set for function to_constraints/2 callback (specified in Ecto.Adapters.SQL.Connection). This either means you forgot to add the "@impl true" annotation before the definition or that you are accidentally overriding this callback
  lib/jamdb_oracle_ecto.ex:142: Ecto.Adapters.Jamdb.Oracle.Connection (module)

warning: module attribute @impl was not set for function table_exists_query/1 callback (specified in Ecto.Adapters.SQL.Connection). This either means you forgot to add the "@impl true" annotation before the definition or that you are accidentally overriding this callback
  lib/jamdb_oracle_ecto.ex:139: Ecto.Adapters.Jamdb.Oracle.Connection (module)

warning: module attribute @impl was not set for function insert/7 callback (specified in Ecto.Adapters.SQL.Connection). This either means you forgot to add the "@impl true" annotation before the definition or that you are accidentally overriding this callback
  lib/jamdb_oracle_ecto.ex:136: Ecto.Adapters.Jamdb.Oracle.Connection (module)

warning: module attribute @impl was not set for function execute_ddl/1 callback (specified in Ecto.Adapters.SQL.Connection). This either means you forgot to add the "@impl true" annotation before the definition or that you are accidentally overriding this callback
  lib/jamdb_oracle_ecto.ex:140: Ecto.Adapters.Jamdb.Oracle.Connection (module)

warning: module attribute @impl was not set for function delete_all/1 callback (specified in Ecto.Adapters.SQL.Connection). This either means you forgot to add the "@impl true" annotation before the definition or that you are accidentally overriding this callback
  lib/jamdb_oracle_ecto.ex:135: Ecto.Adapters.Jamdb.Oracle.Connection (module)

warning: module attribute @impl was not set for function delete/4 callback (specified in Ecto.Adapters.SQL.Connection). This either means you forgot to add the "@impl true" annotation before the definition or that you are accidentally overriding this callback
  lib/jamdb_oracle_ecto.ex:138: Ecto.Adapters.Jamdb.Oracle.Connection (module)

warning: module attribute @impl was not set for function ddl_logs/1 callback (specified in Ecto.Adapters.SQL.Connection). This either means you forgot to add the "@impl true" annotation before the definition or that you are accidentally overriding this callback
  lib/jamdb_oracle_ecto.ex:141: Ecto.Adapters.Jamdb.Oracle.Connection (module)

warning: module attribute @impl was not set for function all/1 callback (specified in Ecto.Adapters.SQL.Connection). This either means you forgot to add the "@impl true" annotation before the definition or that you are accidentally overriding this callback
  lib/jamdb_oracle_ecto.ex:133: Ecto.Adapters.Jamdb.Oracle.Connection (module)
vstavskyi commented

I have only one warning: calling super for GenServer callback child_spec/1 is deprecated
lib/db_connection/connection_pool.ex:23: DBConnection.ConnectionPool.child_spec/1

OTP 23.3.4.10
Elixir 1.10.4

winks commented

Oh, that could be it.

Erlang/OTP 24 [erts-12.2.1] (24.2.1)
Elixir 1.13.2 (compiled with Erlang/OTP 24)
vstavskyi commented

@impl is needed

commit

winks commented

Manually replacing the file with the one you committed fixes every warning for me, thank you!

Can be closed from my point of view.

  • 👍1