ermongroup/cs228-notes

Coherence in JT Algorithm Lecture Notes

manonromain opened this issue · 0 comments

Hi! In the Junction Tree Algorithm Lecture Notes, I noted some inconsistencies w.r.t. factor graphs. In - that order, I quote:

  • First: "Sum-product message passing can also be applied to factor trees with a slight modification. Recall that a factor graph is a bipartite graph with edges going between variables and factors, with an edge signifying a factor depends on a variable." but factor trees are not mentioned before in the lecture notes.
  • Later, note 5. : "Arbitrary potentials can be handled using an algorithm called LBP on factor graphs. We will include this material at some point in the future."

Reading the notes and understanding what factor trees/graphs is doable, but the phrasing/order is confusing. I'll try submitting a pull request later in the quarter.

Thank you!