es5-shim + angular 1.5 + currency filter crashes safari 8.x

Question

es5-shim + angular 1.5 + currency filter crashes safari 8.x

stringbeans opened this issue 9 years ago · 14 comments

When using the built-in currency filter in Angular 1.5.x , with es5-shim 4.5.8 and browsing with Safari 8.x the browser will crash...

http://plnkr.co/edit/zshIf4lDR0YgUXmHl8ou?p=preview

Answer 1 · 2016-04-19T02:21:27.000Z

Hmm - I see the browser tab freezing. Does this happen without the es5-shim?

Answer 2 · 2016-04-19T04:57:49.000Z

removing es5-shim stops it from freezing @ljharb

Answer 3 · 2016-04-19T05:07:51.000Z

@MikaAK does removing the currency filter usage also stop it from freezing?

Answer 4 · 2016-04-19T05:58:57.000Z

@ljharb removing the currency filter stops the freezing as well. This bug occurs if and only if both es5-shim and the currency filter are being used. I've also tried with other angular filters and it seems like it only occurs with the currency one

Answer 5 · 2016-04-19T05:59:49.000Z

Just to note, I've also tried downgrading to 4.2.x and the error still persists. Have not tried lower versions

Answer 6 · 2016-04-19T06:00:14.000Z

Interesting, OK - this is going to be super hard to figure out because it doesn't error, it freezes.

A few things have happened with angular in the past that I'm pretty sure the currency filter is doing something super weird, and angular isn't interacting well with the es5-shim.

Knowing which version of angular started causing the problem would be very helpful, however.

Answer 7 · 2016-04-19T06:03:37.000Z

@ljharb I have a gut feeling this began occurring when we upgraded to angular 1.5.x. I'll do some tests with 1.4.x tomorrow to see if I can track down when it started happening..

Answer 8 · 2016-04-19T17:28:47.000Z

@ljharb ive found that it occurs in angular 1.4.9 but NOT 1.4.8... so 1.4.9 introduced the breaking change

Answer 9 · 2016-04-19T17:35:25.000Z

@stringbeans Thanks, that's super helpful! Looking at angular/angular.js@v1.4.8...v1.4.9 isn't helping much, sadly :-/

Answer 10 · 2016-04-19T17:38:33.000Z

@ljharb i logged it in the angular repo too so hopefully a maintainer there will have an idea. i also looked at their changelog (https://github.com/angular/angular.js/blob/master/CHANGELOG.md) and for the 1.4.9 release there were changes made to formatNumber which may be the culprit!

Answer 11 · 2016-04-19T17:40:19.000Z

angular/angular.js@9c49eb1 may thus be the commit in question

Answer 12 · 2016-04-19T17:40:45.000Z

I see lots of potential in there for infinite loops.

Answer 13 · 2016-04-21T19:21:27.000Z

Is there actually anything in Safari 8 that needs to be shimmed?

Answer 14 · 2016-04-21T19:35:06.000Z

@Narretz There is something in every single version of every single browser/engine that needs to be shimmed: there does not exist a JS engine that fully complies with ES5, even to this day.