float number problem

Question

float number problem

miroslavboda opened this issue 7 years ago · 6 comments

Hello, i have probleme with mimification in file es-shim.js and with minifi version.

Problem is in float number (1000000000000000128).toFixed(0) !== '1000000000000000128'

when change it to (1000000000000000128.0).toFixed(0) !== '1000000000000000128'

it works fine, report some one else this BUG? Thanks.

PS: problem is when webpack compile npm module es5-shim, i tried to turn off minification, but it didnt work anyway. Only solution was change 1000000000000000128 to 1000000000000000128.0

Thanks,

Miro.

Answer 1 · 2017-05-25T21:23:27.000Z

ahhh, i see the minified version replaces the number with 0xde0b6b3a7640080.

I'm not sure how to work around that; it'd probably require configuring uglifyjs. Are you implying that adding the .0 prevents uglify from shortening that number?

Answer 2 · 2017-05-29T06:43:31.000Z

Yes, implying the . 0 prevents from shortering and prevent from making space, witch maked the error to. I tried to set uglify, but it didnt help.

…

On 25 May 2017, at 23:23, Jordan Harband ***@***.***> wrote: implying

Answer 3 · 2017-05-30T04:46:55.000Z

I tried it, and adding the .0 didn't seem to impact minification at all.

Answer 4 · 2017-05-30T04:54:54.000Z

I'll just hack around it for now; uglify isn't worth tinkering with.

Answer 5 · 2017-05-30T05:46:57.000Z

It doesn't seem that 0xde0b6b3a7640080 representation changes anything, is this a problem in specific engines?

In Chrome all seems fine:

Answer 6 · 2017-05-30T06:09:26.000Z

@medikoo the issue is in browsers where the last comparison returns false - since it’s due to a bug in their number literal parsing/representations, it very likely does depend on the exact way the number literal is typed.