20.1.0 release contains a breaking change
alexzherdev opened this issue · 3 comments
What version of TypeScript are you using?
3.1.3
What version of typescript-eslint-parser are you using?
20.1.0
What did you expect to happen?
When upgrading from 20.0.0 to 20.1.0 there are no breaking changes.
What happened?
As discussed in jsx-eslint/eslint-plugin-react#2032, changing a dep to peerDep in #526 is a breaking change.
Adding a peer dep, or altering the version to make it more restrictive, is a breaking change. The peer dep change should be reverted and saved for v21.
My apologies, I mislabeled the commit as a chore rather than breaking.
I'll revert the commit, cut a patch release, then redo the commit as breaking and cut a major release. I'm traveling today, so I greatly appreciate your patience as I find time to do this in between airline security, etc. Thanks for your understanding!
I think I've published typescript-eslint-parser@20.1.1 reverting the peer dependency change. (I say "I think" because this is the first time I've used our new release pipeline with npm 2FA. I do see commits on GitHub and an artifact on npm, so hopefully all went well.)
I'm about to fly now, so I'll do the second part (apply the commit as breaking and cut major release) later today.