esm7/obsidian-rtl

Messing up Persian Sentences Containing (Bold - Italic- Strikethrough and coded ) English Phrases

Closed this issue · 8 comments

Hi,

I've been experiencing an issue after updating Obsidian or the plugin.

The issue is that when I bold, italicize, strikethrough, an English word or writing a code before an English word or phrase in the middle of a Persian sentence, the text gets messed up in the preview mode.
Capture1

The strange thing is that this bug didn't exist before, and even if I copy and paste my previous writing into a new note, the problem doesn't occur. However, everything gets messed up with newly typed text, as shown in the image above.
I'm not using any custom themes or CSS code.
Thank you again for all your hard work and dedication🌱.

esm7 commented

That's incredibly odd.

  1. It does not happen at Editing Mode at all, right? The issue is only with Reading Mode?
  2. Can you paste here an example text that causes the issue, preferably a couple of lines?
zoli commented

This problem is rooted in my last PR (this line).

We need tests to prevent this kind of breaking changes. I will write some tests and fix this issue afterward.

That's incredibly odd.

  1. It does not happen at Editing Mode at all, right? The issue is only with Reading Mode?
  2. Can you paste here an example text that causes the issue, preferably a couple of lines?

Yes, this issue only occurs in reading mode.
I appreciate your time in advance.

Capture99

به نظر شما نقش ژنتیک در استعداد موسیقی تا چه حد است؟ گروهی از پژوهشگران برای بررسی این موضوع سراغ چند تار موی باقی‌مانده از جناب بتهوون رفته‌اند و دی‌ان‌ای این موسیقیدان بزرگ را بررسی کرده‌اند.در این پژوهش روی یک ویژگی خاص تمرکز داشته‌اند که beat synchronization نام دارد. اگر اهل موسیقی باشید، می‌دانید که هماهنگی حرکات با ضرب‌آهنگ موسیقی اهمیت زیادی دارد.

This problem is rooted in my last PR (this line).

We need tests to prevent this kind of breaking changes. I will write some tests and fix this issue afterward.

Thank you Zoli for your time and effort in always trying to solve problems.
Many of the things you do are helpful for making Obsidian easier to work with, and I am really grateful for that. Tashakor🙏🏼

I updated the plugin today, but there is a problem when you want to use lists, for example:

  • این یک test است.Screenshot_20240513-191152_Obsidian.png

Screenshot_20240513-191050_Obsidian.png

esm7 commented

Obsidian is about to include native mixed RTL support in version 1.6.0 and it will solve this issue. There is no need to continue working it as part of the RTL plugin.

Obsidian is about to include native mixed RTL support in version 1.6.0 and it will solve this issue. There is no need to continue working it as part of the RTL plugin.

Thank you
But it seems that something like this is applied when the language of the program is completely changed:
The interface direction is now mirrored when the app is set to an RTL language.
Many users do not change the language of the application to a language that is RTL, because the entire user interface is mirrored and unbearable.

esm7 commented

I agree, but it's an unrelated feature (I don't think it's part of 1.6.0 yet, it will probably be released in the upcoming days for catalysts as a follow-up 1.6.x version).
The mixed RTL support will be available regardless of the interface languages, just like the RTL plugin does.