importing images fails sometime
Closed this issue · 4 comments
Reinstalled Reclaim
Fresh reclaim-log.txt :
2014-02-03T17:25:04+00:00]: github posted new status: Pushed a commit to danito/reclaim-screenshots. on 2014-01-27 09:55:08
[2014-02-03T17:25:06+00:00]: 8e242206fd85eee0eab17a894c454f2e?d=https%3A%2F%2Fidenticons.github.com%2F53b7b1aacd39816aa21c1a2b6005c688.png&r=x&s=400 is not a valid image.
[2014-02-03T17:25:07+00:00]: 8e242206fd85eee0eab17a894c454f2e?d=https%3A%2F%2Fidenticons.github.com%2F53b7b1aacd39816aa21c1a2b6005c688.png&r=x&s=400 is not a valid image.
[2014-02-03T17:25:07+00:00]: Retrieved set of GitHub events: 2, last seen id: , new last seen id: 1961946025, req-ok: 1
[2014-02-03T17:25:07+00:00]: Retrieved set of GitHub events: 0, last seen id: , new last seen id: 1961946025, req-ok: 0
I think reclaim tries to import some screenshot I pushed, but couldn't.
Actually unrelated to GitHub mod. I see this a lot for facebook & twitter posts. @diplix How is the image detection working? Is it looking for some extension or is it actually looking at the response headers (content-type)?
either the image url is passe don from the service API or the open graph class tries to get an image url. it might very well be, that the open graph class return faulty data from time to time.
however those images in the log might be images afterall. i think this line might be too strict or uable to recognise images that are constructed with arguments. (like /53b7b1aacd39816aa21c1a2b6005c688.png&r=x&s=400)
Ah yeah, that looks like the origin of the issue.