essandess/adblock2privoxy

META: work plan for cureent issues

Closed this issue · 1 comments

Importance (low/medium/severe) and scope of required work (trivial/normal/high).

  • adblock2privoxy compilation fail with GHC 8.4.3 #25
    fix compilation
    Medium - A2P still can be used with GHC 8.0, but needs to be future proof, severity would increase as time passes and older GHC would be phased out from distros
    Normal - Proposed solution seems not to severe to achieve and there are many examples titled tweak for ghc-8.4

  • TODO: remove matched element conversion #24
    implement new feature
    Medium - Most elements are removed by created css files after conversion of ## rules, but some sites require that browser completely does not know existence of certain elements therefore they need to be removed prior to being feed to the client
    High - Design feature from ground up

  • translated records get dot in front which has adverse effects #23
    use prepared patch to fix rules for privoxy
    Severe - Without this many false positive catches may happen
    Trivial - patch is ready for implementation

  • disregarding information following $ #22
    implement new feature
    Severe - Adblock is designed to use filters on certain conditions such as ~third-party to specify whether filter should be used on third-party or first domains. Current implementation uses that filter for all conditions
    High - Requires writing similar converter as in case of ab2p-popup-filter or ab2p-handle-as-image-s but also for script, stylesheet, subdocument and others

  • empty rules #21
    add exceptions for conversion of rules not leading to any host or particular pattern
    Low - workarounds are present
    Normal - Probably requires few regex additions to current converter implementation

  • element hidding whitelists undesired behaviour #20
    redesign whitelist expception handling
    Low - workarounds are present & it could interfere with browsing only or rare
    Normal - Probably requires few regex additions to current converter implementation

  • easylist go.*. rule breaks many sites #19
    use prepared patch to fix rules for privoxy
    Severe - Without this many false positive catches may happen
    Trivial - patch is ready for implementation

  • adblock2privoxy segmentation fault #18
    make sure element hiding directory is empty before new rules are created
    Severe - typical race condition which in worst case scenario can lead to system crash
    Trivial - if exists rm -r ${css_dir}\* before any ## rules are created

  • ab2p.common.css causes breakage on some sites #17

  • separate ab2p-elemhide-common-filter from ab2p-elemhide-filter

  • add all hosts from rules with $generichide to {-filter{ab2p-elemhide-common-filter}}

Medium - about 1% of all sites using element hiding rules may not use generic hide
Trivial/High - Above steps are trivial, but getting converter to process all $generichide rules an add them in right way required coding new feature from ground up

  • version string of filter is truncated if it not composed only of digits #16
    cosmetic change to the task file
    Low - does not change any behavior of converter, just descriptive value
    Trivial - small change required

  • expired rules are not used #15
    implement way for a2p to use other filtersets than only those designed for adblock (eg. adguard)
    Low - without this quite number of rules are skipped, but workaround is present
    Normal - several conditions may have to be added for accepting list other than those for adblock

  • conversion errors - not abp specific #14
    related to bug 22 as it requires additional convertions currently not implemented

  • /#

  • #?#

  • Low - cases are rare and in case of #?# undocumented, but they happen
    Normal - Few changes in regex may be needed to address this issue

  • unblock rules too unspecific for certain sites #13
    duplicate of issue 17, but better describes problem

  • add support pre-processor directives for filters #12
    use only filters which will be understood
    Medium - cases where several approaches are taken for specific software to handle given problem are out there and specially present in lists designed for adguard
    High - Implement feature from ground up

  • css file could use new line for site specific rules #11
    implement proper :style() conversion for css files

  • High - Over 10 thousands rules
    Trivial/High - trivial if only Elements=4000 is changed to Elements=1, but may be high as would require change to way in which css files are created

  • Double rules on filters are too broad #10
    limit converter to generate only one rule line per record
    Medium - I would say high as it leads to creating too many broad rules, but workarounds are present
    Normal - probably requires fixes here and there

  • privoxy crash due to bad filter combination #7
    simple template change, fix ready
    Severe - without fix privoxy crashes
    Trivial - patch is ready

  • adblock2privoxy errors out on several records #6
    implementing new conversion methods where privoxy needs to inject javascript
    High - affects hundreds of pages which require parts of scripts to be blocked prior to being used by the browser
    High - Design feature from ground up

@wmyrda thanks again for compiling this helpful list. All items that can be addressed now have been, so I’m closing this and we can discuss individual issues per item.