Suggestion popup is broken in FF41.0

Question

Suggestion popup is broken in FF41.0

FatOrangutan opened this issue 9 years ago · 21 comments

In Firefox 41.0 (now stable), the text of the suggestions in the URL bar suggestion popup is invisible. The icon next to it is visible, and if I use the arrow keys to get to a suggestion, I can see the suggestion's preview in the URL bar. This leads me to think that the addon is fetching the search results fine, just that the results displayed aren't visible.
Here's a picture:

I had only types 'moz,' used the down arrow key to the get to the second option, and InstantFox updated the URL bar to show 'mozilla firefox.' All this is expected of course, except that the suggestions are themselves invisible.

Does anybody have a fix? Thanks.

Answer 1 · 2015-09-24T14:20:21.000Z

sometimes the suggestion dropdown doesn't show altogether.

Answer 2 · 2015-09-24T20:18:29.000Z

I can confirm that, and all in all the add-on is very buggy. Is someone working on this project at the moment?

Answer 3 · 2015-09-26T15:56:00.000Z

I've fixed this and created a pull request. Last time it took them one week to notice/approve it, so I guess we'll just wait now.

I've packaged the fixed version here if you don't want to wait, but it won't work on FF43+ because it's unverified, and I don't know if it'll correctly auto-update when the official release catches up (it should).

Answer 4 · 2015-09-26T15:57:40.000Z

As for the other bugs (@FeBe95), I intend to take a look at the mouse click and missing last character bugs at some point (when time permits), but they don't affect me much so they're rather low-priority - and it's not my project anyway. Looks like the maintainer has been fairly inactive for the last few years. Pity.

Answer 5 · 2015-09-26T17:02:51.000Z

Thank you for the fix. There is one issue however: sometimes, the URL of the 1st suggestion gets displayed too. For instance, here I had just typed 'wiki': [ignore the different search icon, it is the only change I made to your xpi]

Answer 6 · 2015-09-26T17:14:37.000Z

Hm. That's interesting, but the only change I made was to resolve a JS syntax error - the logic has not changed. It looks like that's intended to mark the URL navigated to by the instant feature, implemented late last year: c1a7ae8 2e49a64

Answer 7 · 2015-09-26T17:26:18.000Z

@Elusive138 Okay, thanks for the fix and the effort you made! Nice to hear that you intend to take a look at the other issues. They persist for such a long time now, I got used to adding a whitespace at the end of each query and I disabled nearly all instant-page-loadings. Also I am rarely using a click to confirm a search, so that's okay with me.

Answer 8 · 2015-09-26T17:55:38.000Z

@Elusive138 I just tried it on a clean profile and can reproduce it reliably: Just type in 'wiki' - the suggestions look all good, but give it a second and it appends an URL to the first entry. Just sometimes, I would have URL's appended to the second and third entries too. For what it's worth, fix-fix's version from here [https://github.com/fix-fix/Instantfox/releases/tag/v3.0.1-beta.3] doesn't seem to have this issue.
Anyways, thank you for your work on this. The other day I went through AMO trying all similar extensions and realizing none of them are as good as InstantFox. Your work to keep this usable is truly appreciated.

Answer 9 · 2015-09-26T18:01:27.000Z

use build menu item from instantfox devel button menu to build a version that doesn't have under experimental features enabled.
You might need https://addons.mozilla.org/en-US/firefox/addon/the-addon-bar/ installed to see instantfox devel button

Answer 10 · 2015-09-27T06:43:06.000Z

@Instantfox Thanks, I wasn't aware of that menu. I've updated the patch release (same link). And thanks for fixing the other major (mouse-click, last-character) issues! :)

Answer 11 · 2015-10-02T02:29:31.000Z

@Elusive138 Really happy that you came back, I never got a reply from you on E-Mailing that issue, so I was afraid you abandoned the add on. Meanwhile I tried omnibar but I didn't like it as much as Instantfox.

A little bug I found is the autocomplete, when I get a suggestion for autocomplete and press the right button, it makes a double letter.

For instanse I enter "g wiki (it suggests pedia, I press right and then it is wikiipedia with double the letter "i".

Anyway happy you took the time to update and all I can do is thank you for your time to continue this add on which is one of my absolute favourites.

Answer 12 · 2015-10-02T03:08:15.000Z

@amaru7 You have the wrong person - @Instantfox is the dev/maintainer for this addon. I'm just some random guy with a PR now and then.

Answer 13 · 2015-10-04T11:58:40.000Z

@Instantfox , @Elusive138 , hey guys. I'm just curious - was the updated version already released ?
I can observe exactly the same issue with my FF 41.0.1 and InstantFox addon 3.0.0.1-signed.

Answer 14 · 2015-10-22T12:39:06.000Z

It would be really cool to get this upgrade out. Search is so much more painful without InstantFox working perfectly.

Answer 15 · 2015-10-22T14:40:02.000Z

@MarkCheshire you can download version with this bug fixed on my releases page.
Unfortunately it's not signed, so it will stop to work in Firefox 44, but I think @Instantfox will come with solution to the situation.

Answer 16 · 2015-10-26T10:59:17.000Z

Great news today I got upgraded to 3.0.2 and the problem appears fixed

Answer 17 · 2015-10-28T03:19:19.000Z

Same here!

Answer 18 · 2015-10-29T11:09:39.000Z

Will this issue get fixed soon? Is this extension alive yet?

Answer 19 · 2015-10-29T11:50:32.000Z

@NyroTheCat are you using the 3.0.2 version?

Answer 20 · 2015-10-29T14:22:38.000Z

oh i'm sorry. my extension just got updated :) waited a long time for this fix

great +1

Answer 21 · 2015-10-29T14:34:08.000Z

Fixed in the most recent release (3.0.2)