Do not bundle estraverse dependency?
nikaspran opened this issue · 1 comments
nikaspran commented
I'd like to suggest creating another rollup artifact without the bundled estraverse.
This would have a few advantages:
- Smaller footprint if estraverse is already included in dependencies of the project that brings this in.
- Allow modifying
estraverse.VisitorKeys
, which would allow using esquery with things like TypeScript and JSX (and be a sensible workaround for #57) - Work more canonically with Node.js projects (i.e. ability to use require cache, dependency resolutions and so on)
If this works, I can prepare a small PR over the next few days. To keep backwards compatibility, I can set it up as a new output artifact that wouldn't impact anything - would that work?
michaelficarra commented
Fixed by #105.