etaler/Etaler

why own llvm smallvector implementation ?

Closed this issue · 2 comments

Hi Martin,
Can you please explain why you had to modify smallvec from the default llvm implementation ? Why not use the original unmodified one ?
Thanks
Lior

Hi,
Because LLVM is a super huge dependency and the only thing I need is smallvec. And I don't expect everyone have LLVM installed on their system. Especially on Windows.

If you found the implementation is interfering with LLVM. I can move it into it's own namespace.

ok. I adapted llvm pretty print for smallvec to ur impl - now it finally looks like normal array :) . I'll PR it in the next batch of changed..
20190804_172836