Subscript operator on empty vector
noma opened this issue · 5 comments
noma commented
Stumbled across this:
COSMA/src/cosma/cosma_pxgemm.cpp
Line 276 in d0ab1dd
should probably use push_back(), as the vector is default initialised in 250.
kabicm commented
Thanks @noma, you are totally right. This was a recent change that was not present in the previous release, so it's a good catch!
kabicm commented
Although it's still unclear why this wasn't caught by our CI tests, as we also run address sanitizer tests on each commit. We will have to investigate it.
noma commented
I'd guess your tests didn't trigger 174 due to lack of a suitable input.
kabicm commented
True, I just verified it and now I see what the problem is. Thanks again for catching this!