Remove free functions from `Helpers.sol` as it breaks compilation
Closed this issue · 2 comments
vladikopl01 commented
I request to change Helpers.sol file to have a library in it with already existing functions because using free functions leads to compilation errors using with @openzeppelin/hardhat-upgrades libs.
More description about that issue is here: OpenZeppelin/openzeppelin-upgrades#917
drortirosh commented
From the attached issue, it seems to be a bug in the openzeppelin-upgrades rewrite mechanism, not anything related to this package.
vladikopl01 commented
From the attached issue, it seems to be a bug in the openzeppelin-upgrades rewrite mechanism, not anything related to this package.
Anyway, I think using free functions is not a good option based on style guides and basic concepts of good-written smart-contracts. It is better to use libraries for such cases.