ethcatherders/EIPIP

Call for Input: Fix Comment in ERC-3448

SamWilsn opened this issue · 4 comments

Call for Input

Decision

Do we merge ethereum/ERCs#429?

If Affirmed

Comment in reference implementation is changed.

If Rejected

ERC-3448 is unchanged.

Method

Rough Consensus

Deadline

July 28, 2024

Checklist

I, the opener of this Call for Input, have completed the following:

  • Filled in a descriptive title.
  • Filled in the "Decision" field.
  • Filled in the "If Affirmed" field.
  • Filled in the "If Rejected" field.
  • Filled in the "Method" field.
  • Filled in the "Deadline" field to be thirty days from creation.
  • Added any relevant background information (or removed the section.)
  • Published a notice in writing to the usual channels frequented by EIP Editors (likely Discord.)
  • Commented on this Call for Input, clearly stating my opinion (or abstention.)

I'm in favour of merging, after a quick bytecode scan.

Given it is correcting a comment, if the ERC author approves then I'm ok with this, even though I am generally against changing final ERCs. The discussions topic on Eth Magicians should be changed to a wiki post and have a corrections section.

ok with the change

seems okay