Replies to comments don't appear

[zzkt]

Replying to a comment by clicking 'Reply' causes an error and the reply is not displayed. This appears to be the case with Firefox and Chrome (at least) using either 'no-skin' or 'colibris'.

[WARN] client - Uncaught Error: Syntax error, unrecognized expression: # .comment-replies-container -- {
   errorId: 'qsfxwnMjfN78K04XiXPN',
   msg: 'Uncaught Error: Syntax error, unrecognized expression: # .comment-replies-container',
   url: '...',
   linenumber: 9,
   userAgent: 'Mozilla/5.0 (Macintosh; Intel Mac OS X 10_14_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/84.0.4140.0 Safari/537.36'
run.sh[24629]: }

looks like the commentId is not getting set correctly...

Etherpad version
Version number: 1.8.3
Git sha: 6210114

Installed plugins
ep_comments_page
ep_etherpad-lite
ep_headings2
ep_markdown
ep_page_view

[JohnMcLear]

Remove ep page view ?

[zzkt]

just saw the DEFUNCT PLUGIN:warning so it's disabled now. I also disabled all other plugins to test it and no change. BUT, adding and replying to comments works on newly created pad.

So, looks like this error is only happening on pads that existed before upgrading to 1.8.3

[JohnMcLear]

Ah bummer. Any idea @seballot ?

[zzkt]

I don't get any errors from the checkAllPads.js script but still testing what happens with rebuildPad.js

[JohnMcLear]

@zzkt I think it's related to how userId is set since changes in 1.8.3, I will try take a look. Is this a fire for you? I have other issues I want to get to first.

[zzkt]

Thanks @JohnMcLear there's no immediate rush but would be great to have it fixed. Can you suggest any possible workarounds?

[JohnMcLear]

No, sorry, not without breaking off what I'm doing.

[seballot]

Hi ! I just did some testing, switching back to version 0.0.35 (before my refactoring), adding a comment, then switch to master, I can still open and reply to the comment. So I cannot manage to reproduce :/

But I found the line of code which is raising this error, it seems in your database you have comment replies without the reference to the comment Id... From what I understand, everytime we do add one reply, it redraws all the replies for all comments, so even if the problem is on a comment different the one you try to reply, it fails. I made a fix for that. Hope this will be enough !

[JohnMcLear]

I merged the fixes into master, please confirm @zzkt that this fixes and I will publish a release.

[zzkt]

Thanks @seballot & @JohnMcLear it's looking good.

[JohnMcLear]

published.