[bug] Should not list emails upon pinging
axic opened this issue · 3 comments
Example from here ethereum/EIPs#3768 (comment):
Some old EIPs have email addresses as opposed to github username, those should be ignored during printing I think. There used to be a way to look up a github username based on an email and that is what the old bot did. If it did found a user, that was pinged.
@axic there are ways for me to search users / I can try to get that functionality back up and running. It's easier to just not include it, though.
also @axic some of these still work, for example on this pull request ethereum/EIPs#3767 greg's email resolves to the correct github username
This is addressed by 950d79d...d627d30
which also adds a bit more logic for better author resolving, but the author's emails will not be included. It's intended behavior that if none can be resolved, that bot explode