Change EIPW to only check modified lines
xinbenlv opened this issue · 3 comments
Currently EIPW will check all lines. Sometimes a contributor comes in and make a small updates that they found about an EIP. Their PR are being blocked by EIPW. Such as
This PR does not touch any mention of "ERC" or "EIP".
said @fulldecent veteran author who might not have time to clean up a EIP he doesn't authored.
Guys this is my first PR to EIPs. I wanted to start with the basics (typos). What is going on? What should I do?
by @0fatih new contributor who intend to help and learn by proposing a small typo fix.
By changing the EIPW to only check modified to make it easier for contributor to contribute.
Exception: If some new editorial rule is important enough to be enforced immediately, it's probably worthy of a batch clean up across EIPs before EIPW start to enforcing this new rule.
CC @SamWilsn to transfer this to the EIPW repository.
Doesn't this defeat the purpose of the linter in the first place? Like strong typing, it's a restriction on what is valid that increases the robustness of the [code/EIP].
In this case, I think we should defer to the 'boy-scout rule': Always leave the code better than you found it.
CC @SamWilsn to transfer this to the EIPW repository.
Until there's a decision (hopefully with an update to EIP-1), I'd prefer to keep process discussion in this repo and use issues on eipw to track implementation.