ethereum/EIPs

Customizable editors

Pandapip1 opened this issue · 12 comments

Pandapip1 commented

Proposed Change

In eip-review-bot, currently there are predefined editor groups depending on the type and category. I propose that, as a stop-gap solution before implementing tags, that we have a slightly more customizable editor list for peer reviewers.

SamWilsn commented

What would this look like?

xinbenlv commented

Can you elaborate what is being proposed here @Pandapip1

Pandapip1 commented

Basically, the config would be updated to look like this:

version: 2
editors:
    Pandapip1:
        - governance # Special category for governance
        - core
        - erc
        ...
    foobar: # Doesn't like NFTs
        - erc
        - !nft
    ...
categories:
    core:
        - category === "Core"
    erc:
        - category === "ERC"
    ...
    nft: # Example of some new features enabled by this
        - requires.split(",").some(eip => ["721", "1155"].includes(eip.trim()))
xinbenlv commented

Is this for peer reviewing (technical feedback) or for editing?

Pandapip1 commented

Both! If you want, I can also extend it so that there are more special categories (governance, editor, reviewer)

SamWilsn commented

So !nft above removes NFT related topics from foobar's purview? Without tags, how does that work?

Pandapip1 commented

The config file specifies the pseudo-tags

Pandapip1 commented

Bump. Surprised the stale bot hasn't given any warnings.

github-actions commented

There has been no activity on this issue for 1 week. It will be closed after 3 months of inactivity.

Pandapip1 commented

Weird... why did I get notified about #6650 (comment) now?

github-actions commented

There has been no activity on this issue for 1 week. It will be closed after 3 months of inactivity.

github-actions commented

This issue was closed due to inactivity. If you are still pursuing it, feel free to reopen it and respond to any feedback.