ethereum/eip-review-bot

Editors shouldn't count as their own approval

SamWilsn opened this issue · 5 comments

For example, @lightclient is both an author and an editor: ethereum/EIPs#6642

I made it so that it double counts for the special case of moving from Stagnant. LMK if that seems unreasonable.

Can we make it so editors don't count as editors for proposals they're authoring in any case? I think that's the most consistent, if more annoying.

Can we make it so editors don't count as editors for proposals they're authoring in any case? I think that's the most consistent, if more annoying.

They don't, or at least, they shouldn't. Is there a case you can point to where this happened?

I thought "double counts" in your comment meant counting as an editor and as an author in the special case of moving out of stagnant.

It does mean that. I thought your comment meant other cases.