ethereum/eth-typing

v2.0.0 is missing in release notes

ulope opened this issue · 2 comments

ulope commented

What was wrong?

There is no mention of v2.0.0 (and if there are any incompatibilities) in the release notes.

carver commented

AFAIK the only "incompatibility" is that mypy wasn't actually enforcing any of the types because we were missing this line:

eth-typing/setup.py

Line 56 in 2616b92

package_data={'eth_typing': ['py.typed']},

So making upgrading to v2 might cause mypy to start erroring out. We have been able to upgrade to eth-typing v2 in most modules without any impact, though.

Naturally, 👍 for adding a note about this to the docs.

  • 👍1
cburgdorf commented

I added the missing release notes. I also created an issue to upgrade this repo to use towncrier #16

  • 👍1