Berlin definitions for clients

Question

Berlin definitions for clients

holiman opened this issue 4 years ago · 7 comments

We need to add berlin definitions for the hive clients, afaict, Nethermind and OE are missing it, at least.

How does a berlin config look for OE and Nethermind?

Answer 1 · 2021-03-07T21:30:50.000Z

Ah: https://github.com/openethereum/openethereum/blob/91e57c803dd1c46c443866e933cc557362d18259/crates/ethcore/res/chainspec/ropsten.json#L151
https://github.com/openethereum/openethereum/blob/91e57c803dd1c46c443866e933cc557362d18259/crates/ethcore/res/chainspec/ropsten.json#L55
https://github.com/openethereum/openethereum/blob/91e57c803dd1c46c443866e933cc557362d18259/crates/ethcore/res/chainspec/ropsten.json#L56

But I wonder what https://github.com/openethereum/openethereum/blob/91e57c803dd1c46c443866e933cc557362d18259/crates/ethcore/res/chainspec/ropsten.json#L54 is?

Answer 2 · 2021-03-07T21:32:50.000Z

ANd nethermind:
https://github.com/NethermindEth/nethermind/blob/3158aa44d6be05a1d969fd9c200fe8d78f6d8947/src/Nethermind/Chains/ropsten.json#L56-L59

Answer 3 · 2021-03-07T21:58:11.000Z

Ok, deployed on prod, let's see how this goes

Answer 4 · 2021-03-08T15:38:01.000Z

But I wonder what https://github.com/openethereum/openethereum/blob/91e57c803dd1c46c443866e933cc557362d18259/crates/ethcore/res/chainspec/ropsten.json#L54 is?
Hi, not sure if I follow

Answer 5 · 2021-03-08T17:06:07.000Z

Hi, not sure if I follow

eip2028Transition -- what's EIP 2028 (seem to be something in Istanbul) ?

Answer 6 · 2021-03-08T17:09:33.000Z

Probably this https://eips.ethereum.org/EIPS/eip-2028 and the block is from Istambul.

Answer 7 · 2021-03-08T17:16:22.000Z

Ah right, I totally missed that, and didn't find the eip 🤷