ethereum/hive

Remove Pre-Merge Tests from `simulators/eth2/engine`, `simulators/ethereum/engine`

marioevz opened this issue · 1 comments

Pre-Merge tests are no longer relevant to the clients and some of them are actively removing code related to Proof-of-work, clique, and other pre-PoS consensus algorithms.

These tests will eventually fail for all clients due to the code removal, so it's just appropriate to remove them from all simulators, to reduce run time, and simplify test code in general.

Tasks

More details:

  • simulators/ethereum/engine/suites/engine/tests.go
    • All Invalid Transition tests must be removed since they all start from Pre-Merge and tests the PoW->PoS transition
    • If a test verifies that invalid payloads are rejected, they should test the scenario on a purely PoS environment
    • TTD must be zero for all tests.
  • Test suite simulators/ethereum/engine/suites/transition should be removed entirely.

Bullet point 4 was completed by #840

Bullet points 2 and 3 will be completed by #838