ethereum/remix-plugin

Compiler API not consistent

yann300 opened this issue · 4 comments

yann300 commented

The common API from remix-plugins-directory has been removed but the api in remix-plugin still contain an old version.

https://github.com/ethereum/remix-plugins-directory/pull/190/files#diff-cec70245b5c97601abf594a1408261a57dfb0efd0fcd6e5f636b015072f2026fL15

We should check that all the new API added in remix-plugins-directory is reflected in remix-project repo

bunsenstraat commented

@yann300
I'm not sure what to do with storage, provider and wallet. Are they to be part of the IRemixApi? do they need a profile in remixApi? they are not plugins.. don't have methods except for provider.

yann300 commented
  • storage is not defined, thought dgit could be implementing a minimal api that will cover storage
  • provider has only afaik the async function (it already exists in remix-ide)
  • wallet should have all the signing api. basically wallet is a subset of web3 provider (which only contains functions for signing) -- to be discussed..
bunsenstraat commented

The thing is the API doesn't expose any interface at this point that is not directly related to a plugin through a profile. So for the provider: what should be exposed in the IDE?

yann300 commented

for the web3 provider, sendAsync is enough