scrypt example not compliant with RFC 7914
michaelsbradleyjr opened this issue · 1 comments
The revision comment is: "reverting previous change - test result was calculated with inverted values".
However r=1, p=8 is quite problematic. See:
ethereum/go-ethereum#19977
golang/go#33703
nodejs/node#28799 (comment)
Summary: the test result was calculated with values that are not compliant with RFC 7914 (nor the original paper) that defines scrypt (N < 2^(128 * r / 8)) must be true). The likely explanation is that the test result was calculated with the help of Go's scrypt implementation, which itself is not compliant with the RFC (see the golang/go issue linked above).
This is already resulting in portability problems and some careful thought needs to be given as to how the situation can be remedied without causing a "breaking change" fiasco.