ethereum/yellowpaper

EIP140: REVERT

Closed this issue · 5 comments

pirapira commented

This issue keeps track of adoption of ethereum/EIPs#206 and https://github.com/ethereum/EIPs/pull/207/files, which introduce the REVERT instruction.

EDIT: ethereum/EIPs#207 is not about protocol consensus anyway, so not relevant for the Yellow Paper.

pirapira commented
  • The sentence "no instruction can, through its instruction, cause an exceptional halt" needs to be changed.
pirapira commented
  • \Xi and \Lambda needs to return gas after REVERT.
pirapira commented

#238 and #239 needs to be fixed first. Otherwise, the gas-returning nature of REVERT cannot be expressed.

msuiche commented

@pirapira Can we expect the REVERT instruction to be appended to the yellowpaper ?

If not it would be misleading to not have every instruction documented by the yellowpaper, especially when they can be found in the instruction list of the source code of Solidity:
https://github.com/ethereum/solidity/blob/develop/libevmasm/Instruction.cpp#L162

Or is it because it hasn't been merge to release branch yet ?

pirapira commented

@msuiche there is a pull-request #242 about that.

  • 👍1