Remove dependency on node-hid
pgebheim opened this issue · 1 comments
Can we use dependency injection to pass in one of the transports from the new ledgerjs libs?
https://www.npmjs.com/package/@ledgerhq/hw-transport-u2f
https://www.npmjs.com/package/@ledgerhq/hw-transport-hid
This would mean that deps that only need browser wouldn't need to deal with node-hid dependency which is a pain in many ways including limiting node10 support.
I believe those packages are for the new ledgerjs
library, but we are on the legacy ledgerco
library. Also, requiring the user to dependency inject adds complication to library configuration and thus increases support burden.
That being said, I do hate native module dependencies, especially when they aren't actually needed for your use case. Going to leave this open for now and decide later whether to do it or not.