etienne-martin/device-detector-js

Missing dist/index.js

luluiscute7 opened this issue · 3 comments

luluiscute7 commented

Version 2.2.3 , 2.2.4
Could not found to dist/index.js,,

so my app is crash down..!!
please fix it!

etienne-martin commented

Thanks for letting me know! Somehow adding the resolveJsonModule option in my previous PR completely messed up the folder structure of the dist folder.

I added a new test to prevent this kind of error from happening in the future: https://github.com/etienne-martin/device-detector-js/blob/master/src/tests/lib.test.ts

The issue has been fixed, version 2.2.5 is being published on npm at the moment.

etienne-martin commented

As a sidenote, you might want to build/test your app in a ci/cd pipeline of some sort to catch these kind of errors prior to deploying to production.

etienne-martin commented

Alright, version 2.2.5 is now on npm. Everything should be back to normal, thanks again for letting me know about the issue.