etienne-martin/device-detector-js

Fixtures directory removed on updating

whimsicaldreamer opened this issue ยท 6 comments

On running yarn fixtures the directory gets removed and is not recreated. Thus tests throws errors.

Dev Environment: Windows 10

I had to edit this line
destination = destination.replace("node_modules/device-detector", "fixtures");
to
destination = destination.replace("node_modules\\device-detector", "fixtures");
in load-fixtures.js to get it working.

Am thinking of doing a PR with the updated version of the library and with this fix. Let me know if I am on the correct track.

BTW, some tests are failing with the yandex browser with difference in version number. Not sure how to fix that.

Looks like the backslash thingy fixed the issue for you on windows but broke it for me on mac ๐Ÿ˜•

Fixed it in: #76

Let me know if that still works for you.

Yep it does fixes the issue. Sorry for the trouble. ๐Ÿ˜ž

All good, thanks for the fix

๐Ÿ˜„ You are welcome.. Will keep watching on this great lib..