Support Browserless/Puppeteer browserWSEndpoint
madflow opened this issue · 4 comments
madflow commented
Feature Request: Support connecting to a browserWSEndpoint
. For example https://www.browserless.io/#integrations
const browser = await puppeteer.connect({
browserWSEndpoint: 'wss://chrome.browserless.io'
});
etienne-martin commented
Good idea, could be useful for some people.
We could add a new connect method to connect to a new browser instance:
const convert = await svgToImg.connect({ endpoint: "wss://chrome.browserless.io" });
And then we would be able to use the normal API like so:
const image = await convert.from("<svg xmlns='http://www.w3.org/2000/svg'/>").toPng();
What do you think?
madflow commented
+1 for using the same API like before! Looks good to me :D
qqilihq commented
Hey there, we needed this as well and I'm currently testing a fork locally where I implemented this. Would you be interested in a PR once I've verified that it works?
etienne-martin commented
@qqilihq Yeah absolutely