etix/mirrorbits

Rsync fails to find files behind symlinks

the-maldridge opened this issue · 4 comments

the-maldridge commented

I have a mirror where several thousand files live behind a symlink which mirrorbits doesn't include in its scan. This seems to be an issue with the hardcoded command line not including --copy-unsafe-links. I'm not sure the best way to handle this within mirrorbits since my general solution would be to just add a flag to enable that. Perhaps this should be a config token?

I'm running on a custom compiled build right now so its not that important, but I think this is something that shouldn't be quite as hard coded.

the-maldridge commented

I "solved" this by using a bind mount, but I think there is likely still a more elegant solution here.

etix commented

We can probably add an "additional rsync parameters" option in the configuration to do that. I wouldn't add --copy-unsafe-links during scan by default though.

fauust commented

Hi!
I am also interested with this enhancement.

In the mean time, @the-maldridge could you kindly share your patch for your custom version?

Thanks!

the-maldridge commented

If I still had it I would gladly share it. After switching to the bind mount I stopped maintaining it and eventually my organization stopped using mirrorbits entirely due to insane memory bloat.

  • 👍1