etn-ccis/blui-angular-workflows

Publishing Happens before Tests Finish

Closed this issue · 1 comments

emclaug2 commented

Describe the bug

Cypress tests are ran after publishing and tagging of packages.

What is the expected behavior?

Package and tag steps should wait for the cypress tests job to finish before executing.

What are the steps to reproduce?

  1. Go observe our latest master merge: https://app.circleci.com/pipelines/github/brightlayer-ui/angular-workflows/184/workflows/4ed0532e-f96a-4451-8271-f63e0ecfa3a0

Screenshots / Screen recording

image

joebochill commented

Need to add an extra dependency on the publish step so it runs after cypress_tests job finishes:
https://github.com/etn-ccis/blui-angular-workflows/blob/dev/.circleci/config.yml#L164