etn-ccis/blui-react-native-workflows

SetPassword has default values set for some props

Closed this issue · 1 comments

surajeaton commented

Describe the bug / expected behavior

  • SetPassword has default values set for some props
  • SetPassword is a base component which we will be using in password related screens
  • There are some hard coded default values set to props newPasswordLabel and confirmPasswordLabel

What are the steps to reproduce?

  1. blui-react-native-workflows/login-workflow/src/components/SetPassword/SetPassword.tsx

    Line 50 in cf8300e

    newPasswordLabel = 'Password',

Screenshots / Screen recording

Code snippet / Link to minimum reproduction example

CODE HERE

Your environment information

Suggested fix

There should be no default values

Anything else to add?

joebochill commented

I'm inclined to say this is okay. There's nothing inherently wrong with a component having fallback default values for optional props. We just need to make sure that in our full components we are passing a translated value appropriately (if we see these default English strings, that will be a good indicator that we missed something in the full screens).