etn-ccis/blui-react-showcase-demo

Menu icon is rendering to the right of the appbar title at mobile viewports

Closed this issue · 4 comments

Describe the bug

Menu icon is rendering to the right of the appbar title at mobile width.

What is the expected behavior?

The menu icon should render to the left of the appbar title at mobile width.

What are the steps to reproduce?

  1. Clone the repo & cd into it.
  2. Run yarn && yarn start
  3. Shrink window to less than 600px width
  4. Observe menu icon in the wrong position

Screenshots or links to minimum reproduction example

Screen Shot 2022-01-12 at 2 18 46 PM

What's the correct position for this Menu element? Should it be aligned to the right? :) Can I please take this issue? I've already created a PR ;)

Just seen that @AlanLes has also worked on / fixed this issue. Regardless of whether or not my change - menu icon on the left of the title - is the correct interpretation feel free to allow them to update their PR and merge that one if you like as they were first.

Okay, great, thanks!

Yes, the icon should be on the left of the text, like this:
image