etsy/skyline

Flagging as an anomaly even though no algorithms failed

Opened this issue · 1 comments

Just started testing out skyline and I started seeing today that skyline was flagging one of my metrics as an anomaly even though none of the algorithms failed. See highlighted below. I did have the CONSENSUS = 1 just increase the sensitivity. Any ideas on why this is happening?

2014-07-31 09:59:08 :: 29238 :: seconds to run :: 0.11
2014-07-31 09:59:08 :: 29238 :: total metrics :: 3
2014-07-31 09:59:08 :: 29238 :: total analyzed :: 0
2014-07-31 09:59:08 :: 29238 :: total anomalies :: 0
2014-07-31 09:59:08 :: 29238 :: exception stats :: {'Stale': 3}
2014-07-31 09:59:08 :: 29238 :: anomaly breakdown :: {}
2014-07-31 09:59:08 :: 29238 :: sleeping due to low run time...
2014-07-31 09:59:18 :: 29238 :: WARNING: skyline is set for more cores than needed.
2014-07-31 09:59:18 :: 29238 :: seconds to run :: 0.08
2014-07-31 09:59:18 :: 29238 :: total metrics :: 3
2014-07-31 09:59:18 :: 29238 :: total analyzed :: 1
2014-07-31 09:59:18 :: 29238 :: total anomalies :: 1
2014-07-31 09:59:18 :: 29238 :: exception stats :: {'Stale': 2}
2014-07-31 09:59:18 :: 29238 :: anomaly breakdown :: {}
2014-07-31 09:59:18 :: 29238 :: sleeping due to low run time...
2014-07-31 09:59:28 :: 29238 :: WARNING: skyline is set for more cores than needed.
2014-07-31 09:59:28 :: 29238 :: seconds to run :: 0.08
2014-07-31 09:59:28 :: 29238 :: total metrics :: 3
2014-07-31 09:59:28 :: 29238 :: total analyzed :: 1
2014-07-31 09:59:28 :: 29238 :: total anomalies :: 1
:

Found the issue. median_absolute_deviation was not setting the return if the test passed. This was causing run_selected_algorithm to view it as != False. I fixed it in my fork:
https://github.com/rugger74/skyline/blob/master/src/analyzer/algorithms.py