0.1.9, 0.1.10, 0.2.0 broken due to export from devDependencies
Closed this issue · 3 comments
I'm submitting a ...
[x] bug report
[ ] feature request
[ ] question about the decisions made in the repository
[ ] question about how to use this project
Summary
PR #115 broke the module by exporting a member of devDependency graphql-tools.
I recommend against adding graphql-tools to the dependency list for people, like me, who don't need it.
If you switch to ESLint a rule could be added to avoid this in the future.
Other information (e.g. detailed explanation, stacktraces, related issues, suggestions how to fix, links for us to have context, eg. StackOverflow, personal fork, etc.)
./node_modules/apollo-link-scalars/build/module/index.js
Module not found: Error: Can't resolve 'graphql-tools' in 'node_modules/apollo-link-scalars/build/module'
You have a point indeed.
1.x exposes this as a dependency instead of a dev-dependency which solves one part of it.
As you said, it is probably better to avoid exposing this altogether. I'll see about create a new major 2.x that removes that dependency, since that would be a breaking change.
For 0.x, since a minor in 0.x world can break, I'll see about release a 0.3.0
Cheers for that
For 0.x, since a minor in 0.x world can break, I'll see about release a 0.3.0
Alternatively you could release 0.1.11 and 0.2.1 for people that lock to ~0.1.x/~0.2.x. People do this to prevent breaking changes with minor updates on packages with 0 as major which can happen as you wrote above.